search

Cambridge-ICCS / practical-ml-with-pytorch

Training material on writing machine learning code with PyTorch by ICCS
https://cambridge-iccs.github.io/practical-ml-with-pytorch/
MIT License
26 stars 27 forks source link

Changes to network achitectures #43

Closed jdenholm closed 5 months ago

jdenholm commented 7 months ago

For some reason the non-linear activation functions have been removed from the models in the solutions. This may well work, but it seems very irregular and, since this is for educational purposes, it should be corrected.

jatkinson1000 commented 7 months ago

Looking at PR #14 they were never there in the first place...?

If you can provide the line for the layer I'll append it to the nets in the notebooks. Should it just be a ReLU layer?

I assume you mean Exercise 1, as the other examples use TorchTools and MobileNet?

jdenholm commented 7 months ago

There were in the original taught version, but I maybe they never made it into the first version of the worked solutions?

jatkinson1000 commented 7 months ago

So a ReLU layer at the end of the net in Exercise 1?