search

CambridgeCentreForProteomics / camprotR

https://cambridgecentreforproteomics.github.io/camprotR/
MIT License
4 stars 0 forks source link

gobbles up some low-hanging testing fruit #13

Closed TomSmithCGAT closed 3 years ago

TomSmithCGAT commented 3 years ago

:yum: :yum: :yum:

This will pass once #12 is merged...

codecov[bot] commented 3 years ago

Codecov Report

Merging #13 into master will increase coverage by 20.68%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
+ Coverage   22.20%   42.88%   +20.68%     
===========================================
  Files          18       18               
  Lines         869      872        +3     
===========================================
+ Hits          193      374      +181     
+ Misses        676      498      -178
Impacted Files Coverage Δ
R/match_id.R 95.83% <100.00%> (+95.83%) :arrow_up:
R/combine_runs.R 4.34% <0.00%> (+4.34%) :arrow_up:
R/ptm.R 37.83% <0.00%> (+37.83%) :arrow_up:
R/silac.R 100.00% <0.00%> (+86.20%) :arrow_up:
R/filter_x.R 100.00% <0.00%> (+100.00%) :arrow_up:
R/theme_camprot.R 100.00% <0.00%> (+100.00%) :arrow_up:
R/get_cat_palette.R 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fe2326...c3f1c31. Read the comment docs.

TomSmithCGAT commented 3 years ago

@csdaw - Happy if I merge this?

csdaw commented 3 years ago

@TomSmithCGAT Go for it!