csdaw commented 3 years ago

Removes stringr (which depends on the very large stringi package) from Imports to Suggests.
Replaces the cut2() function from Hmisc (which has lots of dependencies including stringr and stringi) with the functionally identical cutf2() from the cutr package.

By removing stringi as a recursive dependency, the total Travis build time is reduced from ~1 h to ~10 min. Also reducing camprotR dependencies to a minimum is probably a good idea in general.

codecov[bot] commented 3 years ago

Codecov Report

Merging #17 (07d8b68) into master (6e425e5) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          21       21           
  Lines         889      889           
=======================================
  Hits          392      392           
  Misses        497      497

Impacted Files	Coverage Δ
R/estimate_incorporation.R	`0.00% <0.00%> (ø)`
R/tmt_qc_plots.R	`14.40% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e425e5...07d8b68. Read the comment docs.

TomSmithCGAT commented 3 years ago

Thanks @csdaw! Yes, removing dependencies is definitely a good idea. Feel free to merge if it's ready.

CambridgeCentreForProteomics / camprotR

remove deps #17

Codecov Report