{ts} adding colours - Githubissues

CambridgeCentreForProteomics / camprotR

MIT License

4 stars 0 forks source link

Closed TomSmithCGAT closed 4 years ago

TomSmithCGAT commented 4 years ago

@csdaw - This adds the categorical palettes in http://mkweb.bcgsc.ca/colorblind/palettes.mhtml#page-container as discussed, via a function called get_cat_palette.

Also adds two 'theme' objects as variables accessible within all functions. Not sure whether this is the best way to add these to the package?

csdaw commented 4 years ago

The get_cat_palette function looks good.

Minor comments:

require(ggplot2) at the top of the R/theme.R file should be removed as ggplot2 is already imported in NAMESPACE.
I think the two theme functions could be combined into 1 function with an argument like border = TRUE. And that the function should have a structure like ggplot2 theme_classic in which the font size, etc. are not hard coded (see here)

TomSmithCGAT commented 4 years ago

Thanks for the suggestions @csdaw.