search

CambridgeCentreForProteomics / camprotR

https://cambridgecentreforproteomics.github.io/camprotR/
MIT License
4 stars 0 forks source link

Add MSnSet vignette #28

Closed csdaw closed 2 years ago

csdaw commented 2 years ago

This PR adds a vignette describing how to make and use MSnSets.

TomSmithCGAT commented 2 years ago

@csdaw - I've made some suggested edits to the text.

I think you should also draw readers attention to the existing MSnbase IO vignette in the appropriate places. This also covers the basic structure of an MSnSet and IO.

csdaw commented 2 years ago

@csdaw - I've made some suggested edits to the text.

I think you should also draw readers attention to the existing MSnbase IO vignette in the appropriate places. This also covers the basic structure of an MSnSet and IO.

Will do! I might borrow Figure 3 from that vignette as well. Though, honestly I find the MSnbase vignettes can be a bit dense, especially for beginners/new labbies, which is what prompted me to write this vignette.

I agree with the other suggestions as well, thank you :)

TomSmithCGAT commented 2 years ago

No worries. Nice idea to write it up :grin: