CambridgeCentreForProteomics / camprotR

https://cambridgecentreforproteomics.github.io/camprotR/
MIT License
4 stars 0 forks source link

Revamp tests #31

Closed csdaw closed 2 years ago

csdaw commented 2 years ago

This is a large PR that moves camprotR from using testthat 2nd edition to the 3rd edition. The benefits of this are primarily that if function outputs change, now the diffs are human readable.

This PR includes the following changes:

Note that estimate_incorporation() and the functions in R/go.R have had their tests deleted in this branch. Tests for these functions will be added back in other PRs.

csdaw commented 2 years ago

Trying to access the url ftp://ftp.thegpm.org/fasta/cRAP/crap.fasta is causing the build of crap.Rmd vignette to fail on Ubuntu.

Need to make some changes to cRAP vignette.

csdaw commented 2 years ago

Actually it was calls to http::GET() causing CI failure for Ubuntu, due to issues introduced in Ubuntu 20.04 (see here for details and the workaround I have used).