search

CambridgeCentreForProteomics / camprotR

https://cambridgecentreforproteomics.github.io/camprotR/
MIT License
4 stars 0 forks source link

Ts enable triple silac #51

Closed TomSmithCGAT closed 1 year ago

TomSmithCGAT commented 1 year ago

Previously, the functions to handle SILAC modifications were hardcoded to expect particular modifications.

This PR generalises these functions and adds a new function to provide some default regexes which can be expanded as required.

@csdaw - Do you mind passing a critical eye over this. Thanks!

TomSmithCGAT commented 1 year ago

@csdaw - Would you mind looking into the test fail too. It appears to be trying to find an unavailable action, but I'm not clear where the action in question is defined as it's not in out check-bioc workflow, so assume it's further down the rabbit hole..

csdaw commented 1 year ago

Sure thing!

The check-bioc workflow for this package is a bit out of date. I'm troubleshooting a simpler action (see here which will replace the current one eventually.

csdaw commented 1 year ago

GHA is working again and I've just fixed a tiny typo and added a couple of basic tests.