search

CambridgeEducation / qualtrics_api

Qualtrics REST API Ruby Wrapper (Api version 3)
MIT License
6 stars 8 forks source link

Removing possibly dead code. #14

Closed nglx closed 9 years ago

nglx commented 9 years ago

This removes the code which is not in fact need. The API is tested with and without ActiveSupport.

pallymore commented 9 years ago

hmmm why are you removing SerializableCollection

nglx commented 9 years ago

Well, why do we need it? Both as_json, to_json methods are kinda convoluted and and it's working properly without them so I decided to remove the whole module. But we can have it.

pallymore commented 9 years ago

I don't think the original to_json outputs all the models in the collection in json format

also - I think it's natural to output only the collection array but not the params when doing colleciton.to_json

nglx commented 9 years ago
  1. it does i believe (tested it with and without active-support)
  2. agree

let me close it then.