search

CambridgeSemiticsLab / nena

The North Eastern Neo-Aramaic Database Site
https://nena.ames.cam.ac.uk
5 stars 0 forks source link

Bug: "Dialects with no record" does not display #119

Closed Paul32N closed 1 year ago

Paul32N commented 1 year ago

https://nena.ames.cam.ac.uk/grammar/features/7?is_unknown=true

Starting point Feature 1.1.4. : https://nena.ames.cam.ac.uk/grammar/features/7. I click on "66 have no record".

Unexpected result "No results found"

Expected result: A list of dialects with no record to which I can assign values, based on existing entries as well as a new entry.

Many thanks, James!

jamespstrachan commented 1 year ago

Super clear issue description - thanks!

Regression was caused by the improvement of map-groups to be in-url stateful, easy to fix once found. I have pushed to staging here:

https://nena-staging.ames.cam.ac.uk/grammar/features/170?is_unknown=true

There are a few recent commits out for testing on staging instance (this, csv download, bulk edit fix for Geoffrey). Can these be pushed to production?

Paul32N commented 1 year ago

Sorry for not getting back to you earlier. Thanks, James! This does seem to revolve the issue. However, I don't see the functions that you added for Issue #111. It would be handy to add this also, and then proceed to send this to production as soon as you can.

jamespstrachan commented 1 year ago

I have pushed this to production, along with #111 and #117