search

CambridgeSemiticsLab / nena

The North Eastern Neo-Aramaic Database Site
https://nena.ames.cam.ac.uk
5 stars 0 forks source link

Map not showing all villages (?) #44

Open Paul32N opened 5 years ago

Paul32N commented 5 years ago

https://nena.ames.cam.ac.uk/grammar/features/1543 https://nena.ames.cam.ac.uk/grammar/features/1543/map

Situation:
Comparative dialect query for feature: 6.19.1. Incorporated pronominal object in strong verbs Clicked "See map of this feature". Five villages specified for "Yes". Four villages specified for "empty".

Expected: At least all five villages with "Yes" should show on the map.

Problem: Map does not show properly. Only one "red circle". Only one village shows, the one with "Yes (in third person)".

Request: Could you make sure all villages with "Yes" show on the map as well?

Thanks ever so much! Keep up the good work.

Paul32N commented 5 years ago

Question: Is this a bug that is expected to apply to more cases than just this one?

Paul32N commented 5 years ago

For users in particular:

Question1 : Is "empty" specified as "Does not occur in dialect X" and do we want this to appear on the map as well?

Question 2: Do we want these empty entries to appear also in the "example entries" with actual language data or just the "Yes/No" queries?

jamespstrachan commented 4 years ago

Good bug report - very clear! Thanks, @Paul32N

This is an undesirable behaviour that's come about due to us trying to implement some consistency in cases where a Dialect's description of a feature is, for example, "yes" or "no". Historical data will have strings like "Yes", "yes", "Y" and "Yes (sometimes)" saved as an entry of the Dialect. New data will be forced to choose from one of the pre-defined categories (pre-defined as a list of valid options set on the Feature itself).

In this case "6.19.1. Incorporated pronominal object in strong verbs" has been set up to have only one possible category: "Yes". Some of the DialectFeatures have selected this; one has entry "Yes (in third persons)"; and some have no category or entry chosen.

Currently the map only shows Entries. It could be trivially modified to show Category instead (where applicable). I'm not quite sure what to do while we have data which is a mix of both and blank.

I've pushed a little change that makes it easier to jump from editing a particular DialectFeature to the admin page where that Feature's category list is defined. Should be on staging now (edit: it's not, audio-alignment is), will make its way to production with the next release.