search

CambridgeSemiticsLab / nena

The North Eastern Neo-Aramaic Database Site
https://nena.ames.cam.ac.uk
5 stars 0 forks source link

Thick border around Iran on map interface #57

Closed Paul32N closed 3 years ago

Paul32N commented 3 years ago

https://nena.ames.cam.ac.uk/

Map interface.

For some reason the map shows a thicker and darker border around Iran. This border should be made the same as other borders. Many thanks!

jamespstrachan commented 3 years ago

This was part of the code I inherited from the previous attempt to remake the Nena database. Someone had gone to a lot of effort to re-emphasise this border, I'm guessing because without emphasis the map's dotted border line gets somewhat lost in the mountainous terrain:

image

I have removed it for now, please have a check on staging instance and see what you think: https://nena-staging.ames.cam.ac.uk/

jamespstrachan commented 3 years ago

Hey @Paul32N, in accordance with new UAT process could you please confirm that the changes made in this area to staging instance are non-breaking and fit to go to production? If so please apply the ready for production label. Once all on staging tickets in this batch are also marked ready for production by their requesters I will deploy them all. This ticket can stay open for further discussion, spec and coding work on the same topic or you can close it off when no further dev work or deployment is needed. Let me know if this doesn't makes sense.

Paul32N commented 3 years ago

You're right, the same problem holds for the Iraqi-Turkish border; the mountains obscuring the dotted line. At least it is now consistent. I checked the staging instance and in print view this looks fine. I think this will be good for now.

This was part of the code I inherited from the previous attempt to remake the Nena database. Someone had gone to a lot of effort to re-emphasise this border, I'm guessing because without emphasis the map's dotted border line gets somewhat lost in the mountainous terrain:

image

I have removed it for now, please have a check on staging instance and see what you think: https://nena-staging.ames.cam.ac.uk/

Paul32N commented 3 years ago

I think I'm unable to label issues myself.

Hey @Paul32N, in accordance with new UAT process could you please confirm that the changes made in this area to staging instance are non-breaking and fit to go to production? If so please apply the ready for production label. Once all on staging tickets in this batch are also marked ready for production by their requesters I will deploy them all. This ticket can stay open for further discussion, spec and coding work on the same topic or you can close it off when no further dev work or deployment is needed. Let me know if this doesn't makes sense.

codykingham commented 3 years ago

@Paul32N , I've sent you an ownership invitation

jamespstrachan commented 3 years ago

Closing as now deployed