CamelCaseName / HUB75nano

This Arduino library adds the basic functionality needed to drive a HUB 75 protocol LED Panel up to 64x32 Pixels RGB.
GNU General Public License v3.0
39 stars 6 forks source link

Arduino Pro mini not supported despite is Nano compatible #23

Closed lrtsenar closed 6 months ago

lrtsenar commented 6 months ago

I try to compile this project for Arduino Pro Mini which is a Nano without USB port. It works under ATmega328p like Nano. I think "ARDUINO_AVR_PRO" has to be added to board.h (line 7) like following :

#if defined ARDUINO_AVR_NANO || defined ARDUINO_AVR_PRO

Thanks in advance

CamelCaseName commented 6 months ago

Hi, is the pinout for the pro mini the same? If it is you could just give it a try, I can look into it next week regardless

lrtsenar commented 6 months ago

As I said, they're identical, including pinout. The only difference is the USB port present on Nano. I have several versions of Pro Mini and they're compatible w/ Nano but your library compilation fails w/ Pro Mini. I have downloaded your library by including my modification and no problem occurs.

CamelCaseName commented 6 months ago

awesome, if you want you can open a pr, if not I can also add the fix next week

lrtsenar commented 6 months ago

For information, the modification has to be set in board_methods.h too, at line 20. I can't wait for you to add support for 2 linked panels, for example 2 x (64 x 32) ;-)

CamelCaseName commented 6 months ago

alright, added the pro mini to the library (v2.3.2)