search

Camelcade / Devel-Camelcadedb

Perl module for debugging with Perl5 plugin for IntelliJ
Other
23 stars 9 forks source link

Using ${^TAINT} to enable taint mode support instead of another varia… #46

Closed djstauffer closed 4 years ago

djstauffer commented 4 years ago

…ble.

There seems to be no reason to add an additional CAMELCADEDB_TAINT_MODE_SUPPORT environment variable to enable taint mode support in the debugger, when ${^TAINT} will let us know that taint mode is on, and any time it is on we'll want to untaint the PERL5_DEBUG_HOST and PERL5_DEBUG_PORT variables.

This is in reference to issue #29:

https://github.com/Camelcade/Devel-Camelcadedb/issues/29

djstauffer commented 4 years ago

I wasn't sure if you'd see my comments here:

https://github.com/djstauffer/Devel-Camelcadedb/pull/new/issue%2329

(since the pull request was closed).

I created a second pull request based on your suggestion (which I basically agree with).