Prevent memory leaks and improve performance

CameraKit / blurkit-android

The missing Android blurring library. Fast blur-behind layout that parallels iOS.

MIT License

3.72k stars 309 forks source link

Prevent memory leaks and improve performance #39

Closed PaulWoitaschek closed 5 years ago

PaulWoitaschek commented 5 years ago

In case someone passes an activity, we need to make sure we are using the application context.
In case there is no downscaleFactor set, we don't need to apply a matrix to the canvas

austinkettner commented 5 years ago

@PaulWoitaschek Thanks for submitting this! We are debating how to handle PRs going forward, for example we are thinking about potentially requiring CLAs to be signed.

Will get this wrapped in the next day or two and your changes merged in!

emersoncloud commented 5 years ago

Hey Paul I wanted to follow up on what Austin mentioned earlier. We are not sure of our future plans for the BlurKit project quite yet. To avoid the need for licensing agreements we aren’t going to merge your changes directly. We have resolved your concerns in our latest PR #45. We really appreciate your contributions as it did help contribute to our PR, so definitely PR going forward as it’s a great way to get changes integrated directly =)