CameraKit / blurkit-android

The missing Android blurring library. Fast blur-behind layout that parallels iOS.
MIT License
3.72k stars 309 forks source link

Fix BlurLayout#setAlpha(float) & Closes #41 #42

Closed fython closed 5 years ago

fython commented 5 years ago

Fixed bug by adding mLockedAlpha field to save the actual value of alpha.

I also added an alpha animation demo in sample app module.

emersoncloud commented 5 years ago

Hey @fython I wanted to follow up on your PR. We are not sure of our future plans for the BlurKit project quite yet. To avoid the need for licensing agreements we aren’t going to merge your changes directly. We have resolved your concerns in our latest PR #45. We really appreciate your contributions as it did help contribute to our PR, so definitely PR going forward as it’s a great way to get changes integrated directly =)

fython commented 5 years ago

@emersoncloud You're welcome. This project helps me a lot and the bug has been fixed in time so I am grateful too.

If we have a chance to contribute code again, you could ask me what you want to know directly, such as license aggrement, etc.