search

CameraKit / camerakit-android

Library for Android Camera 1 and 2 APIs. Massively increase stability and reliability of photo and video capture on all Android devices.
https://camerakit.io
MIT License
5.37k stars 879 forks source link

Release v0.13.6 #522

Closed austinkettner closed 5 years ago

nullptr2this commented 5 years ago

@austinkettner Wow, quick turn around on that PR. Thanks. I've actually got another one coming that might solve this one: https://github.com/CameraKit/camerakit-android/issues/385

There is a similar issue with orientation when either switching to or starting out in landscape mode. Wanted to let you know in case you wanna include it in this 0.13.6 update. Thanks again!

austinkettner commented 5 years ago

@nullptr2this nice! Thanks for the heads up, feel free to ref this branch and I can integrate it in before merging.

nullptr2this commented 5 years ago

@austinkettner Is a potential 0.13.6 release going against the grain in terms of the beta work that is ongoing? I really need video and so have been focusing on the 0.13.x stuff. Trying to determine which way to go in terms of potentially getting some of these updates in, if they are accepted, or deploying my own artifacts from my own fork because of timing.

austinkettner commented 5 years ago

We totally understand the need for video + photo and as such have been extending support to the 0.13.x line while the v1.0.0-beta line takes an enormous amount of time to ship. Issuing a 0.13.6 doesn't conflict with our beta work and we intend to keep patching 0.13.x until a final v1.0.0 is out the door, so I think we are safe!

Any changes you make and PR, that we include in this 0.13.6 release, will be available very quickly via Bintray once the release is tagged/merged.

@nullptr2this

nullptr2this commented 5 years ago

@austinkettner Sweet. Thanks for the quick response. Once I get past some of this stuff I am doing that requires 0.13.6 I'll try to jump over and help out on the beta a little when/where I can. Again, thanks!!!

austinkettner commented 5 years ago

No problem! @nullptr2this

Are the latest commits I just merged into this PR (from your PR) the final changes you needed in 0.13.6?

nullptr2this commented 5 years ago

@austinkettner Ha. Yeah, the answer to that question is ...maybe...depending on the way things go with some feature discussions for what we are doing I may or may not submit a PR for enabling/disabling the use of physical device orientation to determine if capture should be rotated if UI is locked in one orientation and the user holds the device in another. That would be augmentation rather than a fix though. Not sure if that is something that should be submitted for a 0.13.x type of build. If not, that is something I can manage in a fork if I need it. Those things I submitted so far seem generally useful fixes though, so...

andreififiita commented 5 years ago

Hello, what is the correct way to use the librari in gradle? if I try implementation 'com.camerakit:camerakit:0.13.6' (or 0.13.5) I get "ERROR: Failed to resolve: com.camerakit:camerakit:0.13.6"

nullptr2this commented 5 years ago

@andreififiita The 0.13.6 release has not been merged and distributed via bintray yet, so you will not be able to get ahold of it via gradle unless you set up your own artifact management.

@austinkettner Does CameraKit do SNAPSHOT builds?

andreififiita commented 5 years ago

@andreififiita The 0.13.6 release has not been merged and distributed via bintray yet, so you will not be able to get ahold of it via gradle unless you set up your own artifact management.

Ok, but how about 0.13.5? I get the same error. What am I doing wrong?

nullptr2this commented 5 years ago

@andreififiita The 0.x.x version of the library operated under a different group ID. Use com.wonderkiln:camerakit:0.13.5

The 1.x.x version has adopted com.camerakit as the groupid.

andreififiita commented 5 years ago

@andreififiita The 0.x.x version of the library operated under a different group ID. Use com.wonderkiln:camerakit:0.13.5

Thank you very much! Are there any other dependencies that are needed?

nullptr2this commented 5 years ago

@andreififiita Gradle should pull transitive dependencies for you. If you are curious about what those might be, you can look in the build.gradle files here in Github for the 0.13.5 tag. Or use the gradle command line to ask for the dependency tree.

https://docs.gradle.org/current/userguide/inspecting_dependencies.html