CameraKit / camerakit-android

Library for Android Camera 1 and 2 APIs. Massively increase stability and reliability of photo and video capture on all Android devices.
https://camerakit.io
MIT License
5.36k stars 878 forks source link

Fix NullPointerException when getting camera preview resolution #563

Open chiel99 opened 5 years ago

chiel99 commented 5 years ago

Found this crash on v0.13.6. This PR fixed the exception when the device is trying the perform view onMeasure() but the camera is not opened yet. So the getCameraPreviewResolution() method will return null (which is fine because the CameraView will adjust later), however, if we also want to invert PreviewSizes, the NullException comes up.

The solution is simply adding the null check.

Logcat: java.lang.NullPointerException: Attempt to invoke virtual method ‘int com.wonderkiln.camerakit.Size.getHeight()’ on a null object reference at com.wonderkiln.camerakit.Camera1.getPreviewResolution(Camera1.java:599) at com.wonderkiln.camerakit.CameraView.getPreviewSize(CameraView.java:518) at com.wonderkiln.camerakit.CameraView.onMeasure(CameraView.java:197)