search

CameraKit / camerakit-ios

Library for iOS Camera API. Massively increase performance and ease of use within your next iOS Project.
Apache License 2.0
686 stars 82 forks source link

Prefix collision with CloudKit framework #10

Closed vmartinelli closed 5 years ago

vmartinelli commented 5 years ago

Hello. Thank you for the initiative to bring this framework for all developers. :)

I'm afraid, however, with the class name prefix you choose, that could be collisions with Apple's CloudKit framework.

Apple suggests that ObjC "safe" prefixes use 3 letters and not only 2 (two letters prefixes would be reserved for Apple use only).

In Swift prefixes are not usually required, so they can be removed and only specified for ObjC compatibility purposes.

I'd suggest using something like CKF ("CameraKitFramework") as prefix while in ObjC (CKFSession, for example). And something like CameraSession, for example, while using it in Swift.

adrianmteo commented 5 years ago

Thank you for contributing to CameraKit! 🙌 Agree, we will find a better naming scheme but most likely keep the prefix due to our ObjC support.

austinkettner commented 5 years ago

Dig the CKF prefix alternative, we will probably use that, thanks @vmartinelli!