Cameron-Grey-Kunstadt / Demultiplex

0 stars 0 forks source link

Pseudocode Feedback #3

Open veryshiny opened 1 month ago

veryshiny commented 1 month ago

Hi,

Your problem is very well defined.

For your function, write_out_record: is it writing out the headers alone or whole records, the name and the description are a bit confusing to understand.

Also for the line get read from the first 4 files: do you mean record here?

I like your first if statement, it sorts out all the unknowns in one step which is highly efficient.

Also the inclusion of the counters is very nice, I think Leslie mentioned that we need to count the number of reads for every possible permutation of indices, so it might be a bit more complicated than a simple counter heh.

Overall, your pseudocode looks great! All the best and I'm excited to see how you write it into code! 😃