search

CameronBieganek / julia-color-themes

VS Code color themes for the Julia language.
Other
9 stars 0 forks source link

Commas no longer in colour #6

Open AquaPore opened 8 months ago

AquaPore commented 8 months ago

pollacco.water@gmail.com

Dear Cameron,

Happy new year with lots of Julia sucess.

Hallo again, I enjoy your theme, I am wandering why I am not able to get the commas in colour, is it by any chance interference with the brackets?

Thanks for any help you may provide, Joseph

CameronBieganek commented 8 months ago

Thanks for reporting! I had not noticed that change yet. Apparently the Julia VS Code extension changed how they tokenize commas. Previously they were assigned the scope meta.bracket, but now they are assigned the default source scope, which is colored with white (the meta.bracket scope is colored orange). I've opened an issue in the repo that contains the Julia TextMate Grammar:

https://github.com/JuliaEditorSupport/atom-language-julia/issues/275

AquaPore commented 4 months ago

Hallo Cameron,

A great thanks for this amazing theme. The comas in colour is still an issue on my computer, therefore my guess is that the problem has not yet resolved.

Thanks for any help you may provide, Joseph

CameronBieganek commented 4 months ago

Hello! Yes, sorry about that. Thanks for the nudge (I might need occasional reminders on this issue). I've been distracted by another side project, but I will try to fix the comma issue soon. The Julia VS Code extension team made an update on their end, now I just need to update things on my end.

AquaPore commented 4 months ago

Thanks no worries please consider this update as very low priority.