search

CameronBodine / PINGMapper

Open-source interface for processing recreation-grade side scan sonar datasets and reproducibly mapping benthic habitat
https://cameronbodine.github.io/PINGMapper/
MIT License
39 stars 3 forks source link

SRC and interpolation #23

Closed CameronBodine closed 2 years ago

CameronBodine commented 2 years ago

https://github.com/CameronBodine/PINGMapper/blob/921ad6bf184b320e3fdb07aa4ce443670534038e/c_sonObj.py#L1315-L1319

Is np.interp the appropriate interpolation method for filling nans after water column removal and slant range correction? Numpy documentation states that the x coordinate sequence should be increasing. Does this mean increasing in value, or that the sequence is ordered? Would kriging be a better option? Need to investigate and talk to Dan.

dbuscombe-usgs commented 2 years ago

Not sure what the question is.... does this method not work? If so, what error do you see? I would say kriging would be overkill

CameronBodine commented 2 years ago

I think I'm overthinking things, and I was confused by numpy's documentation. I don't get errors, and the outputs look good, so I think everything is functioning appropriately. Thanks!