search

CameronRushton / anime-anthology-ui-legacy

Aurelia based anime anthology front end
0 stars 0 forks source link

Some keys don't have values #5

Open CameronRushton opened 5 years ago

CameronRushton commented 5 years ago

If the key doesn't have a value, don't display it

Theres a lot of other data not being displayed for many shows. We need to have some default images if the data simply isnt there from the back end. We should log in the console when there is a url but we can't get to it. image

CameronRushton commented 5 years ago

The fix in place won't be good enough even with modification. (Still keep it though) I've found a strange URL (https://anilist.co/anime/21776/Kobayashisan-Chi-no-Maidragon/) that clashes with other sites URL for the same anime. (https://myanimelist.net/anime/33206/Kobayashi-san_Chi_no_Maid_Dragon) (masterani.me/kobayashi-san-chi-no-maid-dragon)

Note the 'maidragon' & 'maid-dragon'. To fix this, I would suggest writing a % match algorithm and assume it's the same if there's a 90% match. This may not work well for shows with multiple seasons listed though.

Also, I doubt we will care about running into an alternate name like the english or japanese alt, but it might be good to check anyway. (https://www.anime-planet.com/anime/miss-kobayashis-dragon-maid)

CameronRushton commented 5 years ago

image Found that yuru camp never had a name property found. This should be fixed in the back end. If there is no name value, set it to one of the synonyms until the value is set, then remove that name from the synonym list.