CammiePone / The-Box-Trot

I am living in your barrels
Other
5 stars 2 forks source link

Body disappears with FirstPersonModel mod #8

Closed slava110 closed 1 year ago

slava110 commented 1 year ago

First Person Model mod body isn't visible when wearing a barrel image (with F1) image Mod link: https://modrinth.com/mod/first-person-model ModLoader: Quilt 0.17.6 The Box Trot: 1.4 FirstPersonModel: 2.2.0

slava110 commented 1 year ago

As this is mod conflict issue I'm linking issue in another mod's GitHub issue so you will be able to talk about this issue: https://github.com/tr7zw/FirstPersonModel/issues/307

CammiePone commented 1 year ago

that's because it's an overlay, and the first person player models mod turns those off

tr7zw commented 1 year ago

I don't turn them off, I just render the player like in f5. The only way to "fix" this would be to use the built in API to auto disable the firstperson mod while this mod is active(https://github.com/tr7zw/FirstPersonModel/blob/1.19/FPFabric/src/main/java/dev/tr7zw/firstperson/fabric/modsupport/FreecamSupport.java example). Also just now understood what the bug request is in the first place, that this overlay is not there. I thought it was about somehow showing the legs while you're inside the box, which doesn't make any sense.

slava110 commented 1 year ago

@tr7zw, the issue isn't about overlay. I thought I stated it clearly - the issue is that body isn't rendered while you're wearing a barrel. F1 view here is just so you can clearly see that body isn't there. Only legs and arms are visible, floating in the air without body part. Possible fixes for this problem:

That's why I asked about rendering custom model over player without conflicting with FPM rendering. I want to try to implement last fix, rendering the whole barrel model instead of on-screen overlay

tr7zw commented 1 year ago

Option 2 and 3 are not possible/incorrect. So the only real option is to just-auto toggle the mod for the time and use this mods rendering.