Cammisuli / monodon

39 stars 17 forks source link

fix(rust): Consider git and outside local source as external when building the graph #43

Closed pulasthibandara closed 9 months ago

pulasthibandara commented 10 months ago

Problem

When working with dependencies referenced from git and local sources outside the workspace, nx throws an error saying the dependency is outside the workspace.

Ex:

[dependencies]
poem = { git = "https://github.com/poem-web/poem.git", branch = "fix/som-bug-fix" }

or 

poem = { git = "../../../../poem", branch = "fix/som-bug-fix" }

Fix

Check is the dependency is Git or a local path outside the workspace before adding to the graph.

fixes https://github.com/Cammisuli/monodon/issues/40

nx-cloud[bot] commented 9 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 91da092cd05750579bd64750ef051c3f4300ce96. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx affected --target=e2e --exclude monodon --parallel`

✅ Successfully ran 1 target

- [`nx affected --target=build,test,lint --exclude monodon --parallel --max-parallel=3`](https://cloud.nx.app/runs/FUJsL8bvit?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.