search

Camork / file-expander-plugin

A IntelliJ plugin that can explore archive-based file in project view
GNU General Public License v3.0
47 stars 8 forks source link

Add support for viewing zstd compressed files #39

Closed RonCruz closed 10 months ago

RonCruz commented 11 months ago

The following changes are for a new feature request to support viewing (zstd)[https://facebook.github.io/zstd/] compressed files. I took an initial stab at the implementation for this. I'm new to Groovy but it seemed simple enough following the implementation for existing file types.

There is one caveat: accepting this PR does add a new dependency to the project (https://github.com/luben/zstd-jni).

Camork commented 10 months ago

Hi @RonCruz , can we use the pure java implementation aircompressor ? because the JNI implementation will bring every platform's native libraries , that cause the packed plugin size to be huge.

RonCruz commented 10 months ago

@Camork Sure. I've pushed a change to migrate away from ztsd-jni to your suggested library.

Camork commented 10 months ago

Merged to master, I had mixed up archiver and compressor before, I need to refactor the code so that it can auto-detect the compressor and archiver by it's metadata, not only the file name.