search

Campbell-Muscle-Lab / PyMyoVent

PyMyoVent is computer code that simulates an idealized ventricle pumping blood around a single circulation.
http://Campbell-Muscle-Lab.github.io/PyMyoVent/index.html
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Consider simplifying instruction files #13

Closed kenatcampbellmusclelab closed 3 years ago

kenatcampbellmusclelab commented 3 years ago

The instruction file at https://campbell-muscle-lab.github.io/PyMyoVent/pages/demos/baroreceptor/baroreceptor_steady_state.html has place-holders for things that are not active.

See for example, "perturbations": { "perturbation_activation":[false], "volume":{ "start_index": [], "stop_index": [], "increment": [0] }, "valve":{ "aortic":{ "start_index": [], "stop_index": [], "increment": [0] }, "mitral":{ "start_index": [], "stop_index": [], "increment": [0] } }

Unless @HosseinGit prefers strongly otherwise, Ken would prefer things being absent unless specifically included in the instruction file. This would keep the files shorter and simpler and make it easier to add options later on.

HosseinSharifii commented 3 years ago

This issued was discussed with Jonathan, Kurtis and Ken once and it was decided to not have those sections that are not being used in the instruction file. But it was supposed to be implemented after the initial baroreceptor paper was finished.

Hossein is now updating the document website with the new format for the instruction file and still being completed.

kenatcampbellmusclelab commented 3 years ago

Handled with redesign