search

CampusMadridProjects / directory-backend

Campus Directory Backend. It uses Cloud Functions for Firebase as entry point, and stores data in Firestore.
MIT License
1 stars 0 forks source link

Read db files fail if there are in a folder. #4

Closed CodingCarlos closed 6 years ago

CodingCarlos commented 6 years ago

It fails by reading the file, but I think the real problem is it cannot wite the file with a name containing / characters.

Would be a good idea to enable, as we have for file names, a constant to update the containing folder.

musikame commented 6 years ago

@CodingCarlos in case this is related to the Cloudstorage bucket and db json files I can move to the root folder - let me know?

CodingCarlos commented 6 years ago

Yes, that's the thing.

Move the files to root folder would be a workaround to avoid the issue, but the bug would still being there.

The fix is easy, so I think that fix it it's better than work in the edge cases ;)

Thx!

El 6 ago. 2018 10:08, "Edu Duque" notifications@github.com escribió:

@CodingCarlos https://github.com/CodingCarlos in case this is related to the Cloudstorage bucket and db json files I can move to the root folder - let me know?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CampusMadridProjects/directory-backend/issues/4#issuecomment-410624007, or mute the thread https://github.com/notifications/unsubscribe-auth/AHDVP_8vcY5rsvV70GTbaSNeHuJe9Edqks5uN_lzgaJpZM4VvV-g .

musikame commented 6 years ago

Sounds good, in case a temp workaround helps to unlock this let me know so we can update the spreadsheet script to upload to the root folder- Gcs!

CodingCarlos commented 6 years ago

Pull request launched! #5

musikame commented 6 years ago

Let me know if you need help with the json upload from the spreadsheet (you have rights to perform the push)