CanCLID / inject-jyutping

A browser extension that adds Cantonese pronunciation (Jyutping) on Chinese characters
https://chromewebstore.google.com/detail/inject-jyutping/lfgpgjkjglogbndlkikjgbbfoiofbdjp
BSD 2-Clause "Simplified" License
73 stars 10 forks source link

Chrome store publish rejected #10

Closed laubonghaudoi closed 1 month ago

laubonghaudoi commented 4 months ago

我喺開發者頁面收到呢個提示

image

https://developer.chrome.com/docs/extensions/develop/migrate/what-is-mv3

graphemecluster commented 4 months ago

咁奇怪?而家已經係 V3 嚟㗎喇噃

laubonghaudoi commented 4 months ago

可能係講緊舊版,等新嘅發佈應該會好返

laubonghaudoi commented 4 months ago
image

@graphemecluster 啱啱得到呢個更新,話係

Violation type: Spam and Placement in the Store Details

我係去 https://github.com/CanCLID/inject-jyutping/releases/tag/0.4.0 度下載個 zip 直接上傳嘅,之前噉樣都冇問題,今次會係咩原因?

graphemecluster commented 4 months ago

我估係因為 detect 到有 directory name 叫 node_modules 就自動黃標,cp 出嚟就冇問題?(亂估)

graphemecluster commented 4 months ago

其他 store 有冇問題?

laubonghaudoi commented 4 months ago

噉以前嘅版本就冇呢個 node_modules?呢個同manifest 有關咩?

我冇其他store,firefox嘅發佈係 @ayaka14732 整嘅,要問佢

graphemecluster commented 3 months ago

@laubonghaudoi 你而家試多次?

laubonghaudoi commented 3 months ago

已經提交,等結果

laubonghaudoi commented 3 months ago

好似又拒絕咗,但係佢上面寫住嘅版本號仲係0.4.0唔係0.4.1,你係咪唔記得更新個版本號?

image
laubonghaudoi commented 3 months ago

呢度仲係 0.4.0 唔係 0.4.1 https://github.com/CanCLID/inject-jyutping/blob/main/manifest.json#L4

不過你睇個截圖入面好似仲有另一個問題Could not load javascript 'lib/webextension-polyfill.js' for script

graphemecluster commented 3 months ago

Reproduce 唔到,我呢度係 work 嘅 Version number 的確係我唔記得更新(改咗 package.json 唔記得改 manifest.json),不過其實冇所謂,因為 0.4.0 根本未發佈

laubonghaudoi commented 3 months ago

咁奇怪,噉而家點算?我有冇辦法可以幫你debug?我唔知呢個版本號唔一致嘅問題會唔會導致佢出錯

graphemecluster commented 3 months ago

唔會,package.json 係 for development 嘅,zip 度冇

graphemecluster commented 2 months ago

@laubonghaudoi @ayaka14732 試下呢個新 release https://github.com/CanCLID/inject-jyutping/releases/tag/0.5.0 放上 Chrome、Firefox、Edge ※ 有 minify 到,記得交 source code

laubonghaudoi commented 1 month ago

啱啱提交咗,等結果。佢個提交係冇得交源代碼嘅,淨得個 zip 交上去。

laubonghaudoi commented 1 month ago

終於成功 https://chromewebstore.google.com/detail/inject-jyutping/lfgpgjkjglogbndlkikjgbbfoiofbdjp @graphemecluster 唔該晒!