CanCLID / rime-cantonese-upstream

rime-cantonese 上游詞表倉庫
Creative Commons Attribution 4.0 International
27 stars 10 forks source link

Large batch of single character amendments #33

Closed jkwchui closed 1 year ago

jkwchui commented 1 year ago

Over the past weeks I diligently went through the single character pronunciations for about 6,200 entries, and identified about 200 items that I believe is better served by an amendment. At the moment I have the items in a CSV file of the following format:

char old new
tung2 tung4
jim4 sim4
nim4 zim1
leoi3 leoi6
jyun4 jyun6
jin4 sin6
hiu3 kiu4

Given the scope, maintainers would probably need discussion of whether each entry is included or not. What is the best way of facilitating that process?

laubonghaudoi commented 1 year ago

多謝你嘅貢獻。最好開一個 PR,然後我哋可以逐個檢查然後提意見。

jkwchui commented 1 year ago

Now that I start merging my changes into char.csv, it looks like the issue is not with rime-upstream but that PyCantonese takes the first match regardless of its tag (e.g., accepting 罕見 instead of 預設). I'll continue through the list but it looks like I should be raising the issue with them instead.