Closed danipilze closed 11 years ago
wow, thank you.
You used the complete ISO 3166-2 code (e.g. CO-ANT
and not ANT
alone).
The reason why we used only the right part (province/state) was mainly because of the original Java enum in canadensys-core. Maybe we should update that to the official one (like you did). @peterdesmet your thoughts?
ok, sorry for the "CO-" predicate, i can easily remove it, or just let it as committed if you want to change the enum in canadensys-core.
I have no preference between the full iso code (CO-ANT
) or the suffix (ANT
). On the one hand, the file name already indicates the country, on the other the long code is more correct and more versatile.
Your call @cgendreau! :hammer:
ok, from now, we are working with the full ISO 3166-2 code. canadensys-core
1.5 will use the full code (already commited). So, @danipilze this Pull Request is fine, just need the enum to release it. Were you planning to add the enum for Columbia? I could also do it. Thanks again.
Want me to update the files for Belgium? If yes, what files exactly? :-)
All the files are updated (not pushed yet)
@cgendreau may you please add the enum for Colombia? thanks.
Done, could you review it (https://github.com/Canadensys/canadensys-core/commit/86eb6842d98ccfe018814b500c2c4892e4c5b19a) before I release canadensys-core 1.5? Thanks
that's great! the enum is ok
Adding dictionary for colombian departments (state/provinces) according to ISO_3166-2:CO http://en.wikipedia.org/wiki/ISO_3166-2:CO