Canadian-Geospatial-Platform / geoview

Canadian Geospatial Platform Viewer / Visualiseur de la Plateforme Géospatiale Canadienne
Other
22 stars 31 forks source link

feat(footerbar): timeslider #closes2232 #2244

Closed kaminderpal closed 1 month ago

kaminderpal commented 1 month ago

Description

1) Fix the size of tabs in footer bar 2) Add guide feature for time slider plugin

Fixes #2232

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy! https://kaminderpal.github.io/geoview/add-layers.html https://kaminderpal.github.io/geoview/demos-navigator.html?config=./configs/navigator/06-basic-footer.json

Checklist:


This change is Reviewable

cphelefu commented 1 month ago

packages/geoview-core/src/core/components/footer-bar/footer-bar-style.ts line 34 at r1 (raw file):

      margin: '0.5rem',
      minHeight: 0,
    },

Maybe we can add this styling to ui/styles/themeOptionsGenerator (under components) so that this styling is applied to all Tabs components used in the application.

cphelefu commented 1 month ago

packages/geoview-core/src/ui/tabs/tabs-style.ts line 22 at r1 (raw file):

    fontWeight: 'bold',
    minWidth: 'min(4vw, 24px)',
    padding: '8px 2%',

can change to 0.5rem. Optional.

cphelefu commented 1 month ago

packages/geoview-core/src/core/components/footer-bar/footer-bar.tsx line 161 at r2 (raw file):

      return { ...prevState, ...newTab };
    });
  }, []);

Did you mean to remove [tabsList] here?

cphelefu commented 1 month ago

packages/geoview-core/src/core/components/footer-bar/footer-bar-style.ts line 34 at r1 (raw file):

Previously, kaminderpal (Kamy) wrote…
Done.

Hmm. my bad. If we do this it will make every flexContainer have 56px.. maybe I was wrong. This can be dangerous if we ever add another tab component. My apologies.