Canadian-Geospatial-Platform / geoview

Canadian Geospatial Platform Viewer / Visualiseur de la Plateforme Géospatiale Canadienne

Other

20 stars 31 forks source link

fix static map scale #2317

Closed cphelefu closed 1 week ago

cphelefu commented 1 week ago

Description

Fixes the horizontal scroll to be same height as width of vertical scroll.
Fixes color of scale in static mode.

Fixes #2316 Fixes #2306 Fixes #2318 Fixes #2320

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

https://cphelefu.github.io/geoview/demos-navigator.html?config=./configs/navigator/06-basic-footer.json (make sure scrolls are the same)

https://cphelefu.github.io/geoview/default-config.html?p=3857&z=4&c=-100,40&l=en&t=dark&b=basemapId:transport,shaded:false,labeled:true&i=dynamic&cc=overview-map&keys=12acd145-626a-49eb-b850-0a59c9bc7506,ccc75c12-5acc-4a6a-959f-ef6f621147b9#HLCONF6 (Make sure scale lines have same color)

Checklist:

[x] I have build (rush build) and deploy (rush host) my PR
[x] I have connected the issues(s) to this PR
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have created new issue(s) related to the outcome of this PR is needed
~~I have made corresponding changes to the documentation~~
~~I have added tests that prove my fix is effective or that my feature works~~
~~New and existing unit tests pass locally with my changes~~

This change is