Canadian-Geospatial-Platform / geoview

Canadian Geospatial Platform Viewer / Visualiseur de la Plateforme Géospatiale Canadienne

Other

20 stars 31 forks source link

fix(zoom-extent) - Safer zoomToExtent function, preventing an infinite loop in OpenLayers #2322

Closed Alex-NRCan closed 1 week ago

Alex-NRCan commented 1 week ago

Description

Safer zoomToExtent function, preventing an infinite loop in OpenLayers.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Hosted, June 27th, 11h30: https://alex-nrcan.github.io/geoview/demos-navigator.html?config=./configs/navigator/14-wms-layer.json 1- Zoom to Ice Cover layer 2- Notice how it doesn't break the application and causing an infinite loop anymore (open console to see the infinite loop in upstream)

Checklist:

[x] I have build (rush build) and deploy (rush host) my PR
[ ] I have connected the issues(s) to this PR
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have created new issue(s) related to the outcome of this PR is needed
~~I have made corresponding changes to the documentation~~
~~I have added tests that prove my fix is effective or that my feature works~~
~~New and existing unit tests pass locally with my changes~~

This change is