Canardoux / flutter_sound

Flutter plugin for sound. Audio recorder and player.
Mozilla Public License 2.0
877 stars 572 forks source link

[enh] Too many dependencies #480

Open KieranLafferty opened 4 years ago

KieranLafferty commented 4 years ago

Flutter Sound Version :


Severity


Platforms you faced the error

All

Logs

(This is very important. Most of the time we cannot do anything if we do not have information on your bug)

[apps/project] flutter pub upgrade
Running "flutter pub upgrade" in project...                        
Because project depends on flutter_sound ^6.0.0 which depends on logger ^0.7.0+2, logger ^0.7.0+2 is required.

Describe the bug The logger dependency in this package prevents me from upgrading logger past "0.7.0+2"

Ideally just remove logger entirely as a dependency since logging can be handled by the person implementing. If keeping it in would be great to have it updated to the latest version

To Reproduce Add flutter_sound to pods and run pod update and observe that logger version is capped to "0.7.0+2"

Expected behavior flutter_sound does not insist on a specific version of logger


Additional context**

Add any other context about the problem here.

KieranLafferty commented 4 years ago

After diving into the codebase and attempting the change myself I realized this isn't as straight forward as I had thought it would be

Larpoux commented 4 years ago

My thinking is that there is too many dependencies required by the WidgetUI. Someone should look to this code which is (I think) too much complicated for doing something very simple.

Larpoux commented 3 years ago

The depency is now : logger: ^0.9.4

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days.