Improve message method in MessageReceiver.java

CanaryModTeam / CanaryLib

The CanaryMod API Library

http://canarymod.net

28 stars 22 forks source link

Improve message method in MessageReceiver.java #46

Closed jamierocks closed 9 years ago

jamierocks commented 9 years ago

I think it would be useful to remove the method message(String msg) in MessageReceiver.java in favour of new varargs and List/String[] versions. This would be similar to this.

Larry1123 commented 9 years ago

Why leave that at,

void message(Iterable<String> messages)

When it could be,

void message(Iterable<? extends CharSequence> messages)

But I like the idea myself.

jamierocks commented 9 years ago

Thanks, never heard of CharSequence before (I don't think).

Larry1123 commented 9 years ago

I would like to here from a few others on this topic before this gets done as it will change some underlying code.