search

CanastaWiki / Canasta-CLI

The Canasta command line interface, written in Go
MIT License
5 stars 14 forks source link

Change default directory permissions to be more restrictive (#46) #71

Closed bawolff closed 9 months ago

bawolff commented 1 year ago

Make the config directory be 0755. Make the restic backups directory be 0700.

Fixes #64

naresh-kumar-babu commented 9 months ago

@bawolff '0o700' should change to '0700' and '0o755' to '0755'.

bawolff commented 9 months ago

@bawolff '0o700' should change to '0700' and '0o755' to '0755'.

Why?

I mean, i dont really care either way, but is there a reason you think one is better than the other?

naresh-kumar-babu commented 9 months ago

Yeah, this is the common format for permission modes

jeffw16 commented 9 months ago

Naresh, that might be true, but is there a reason 0o755 is flat out wrong? Otherwise, I don't see what the problem is. It's personal preference. Unless you think that this is confusing to the majority of people (which I can see being a problem), we shouldn't point out issues that are not actually issues.

bawolff commented 9 months ago

For context, 0755 is traditional because 0o755 is much newer format. Some people feel that it is very easy to misread 0755 and not see the leading 0, where 0o is much more obvious what is going on. I don't have a strong preference either way

naresh-kumar-babu commented 9 months ago

@bawolff I didn't mean that it was wrong. It's just that we are used to 0755 a lot. It's more known than the latter. But as you said, it does not bring any functional advantages. It's up to you.