search

CanastaWiki / Canasta-CLI

The Canasta command line interface, written in Go
MIT License
5 stars 14 forks source link

Remove automatically-added wfLoadSkin() calls from LocalSettings.php #85

Closed hexmode closed 1 year ago

hexmode commented 1 year ago

While moving wikiapiary, we noticed all the enabled skins were enabled in the embedded LocalSettings.php and could not (easily) be disabled. The embedded LocalSettings should include as little customization possible and, where possible, it should be modifiable.

jeffw16 commented 1 year ago

I know what's going on here. On startup, Canasta symlinks all of our bundled skins to the skins directory that MediaWiki sees. MediaWiki Core sees these directories and its install.php script auto-generates these lines.

jeffw16 commented 1 year ago

We're already using the settings directory to enable Vector by default. We should probably add something in the CLI to remove these lines from LS after the installation completes. This bug doesn't apply to manual installs of MediaWiki on Canasta that don't use CLIs.

yaronkoren commented 1 year ago

I just renamed the issue - hopefully this accurately sums it up.