search

CanastaWiki / Canasta-DockerCompose

Docker Compose stack template for Canasta
MIT License
13 stars 15 forks source link

Removes image from docker-compose.override.yml #44

Closed vedmaka closed 1 year ago

vedmaka commented 1 year ago

The fact that docker-compose.override.yml contains an override for the web service image property may be confusing because the override file is loaded automatically by the Compose and thus until removed or commented out, if left untouched the stack will always try to load version 1.3.0 of the image regardless of the image property value at docker-compose.yml file.

I'd suggest keeping the override file in place, but commenting all the overrides out from it

jeffw16 commented 1 year ago

But that was the intention: to fix the version used to a specific version. If we used the latest version all the time, then the user's wiki might be updated unpredictably.

Anyone else have thoughts on this?

vedmaka commented 1 year ago

Using a specific version as a default makes sense, but then it'd be better to have the specific version set at https://github.com/CanastaWiki/Canasta-DockerCompose/blob/main/docker-compose.yml#L26 instead of the override file

freephile commented 1 year ago

Vedmaka's suggestion sounds good to me.

Greg Rundlett

On Wed, May 24, 2023 at 12:41 PM Vedmaka @.***> wrote:

Using a specific version as a default makes sense, but then it'd be better to have the specific version set at https://github.com/CanastaWiki/Canasta-DockerCompose/blob/main/docker-compose.yml#L26 instead of the override file

— Reply to this email directly, view it on GitHub https://github.com/CanastaWiki/Canasta-DockerCompose/pull/44#issuecomment-1561564907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJLYFO2NJF5JDFIPCB4PDXHY24BANCNFSM6AAAAAAYNSYOGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>