search

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 28 forks source link

Hardcoded docker host address #126

Closed vedmaka closed 2 years ago

vedmaka commented 2 years ago

There is a need for container to connect to Docker host for:

  1. Sending emails
  2. Do VisualEditor Parsoid API calls

Right now there is a hard-coded default 172.17.0.1 [1] [2] address for Docker host being used, this works fine most of the time, however, considering default bridge network may vary either due to changes made to Docker daemon.json configuration file on target host or due to hitting limit of subnets occupied.

It'd be better to have this address detected automatically, fortunately, starting Docker 20.04 this is possible via --add-host=host.docker.internal:host-gateway param or extra_hosts attribute in a Compose file

yaronkoren commented 2 years ago

Closing, given that this seems to have been fixed in August.