search

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 28 forks source link

Add header warning to some special pages if $wgSMTP not set #194

Closed yaronkoren closed 1 year ago

yaronkoren commented 1 year ago

Fixes #145.

A new version of the now-abandoned #187.

github-actions[bot] commented 1 year ago

Image is built and pushed to the repository as ghcr.io/canastawiki/canasta:1.39.0-20221222-194

tosfos commented 1 year ago

Shouldn't it check if $wgEnableEmail is true?

yaronkoren commented 1 year ago

How interesting - I didn't know about that setting. I looked it up, and also saw this, which is specifically for Special:Emailuser:

https://www.mediawiki.org/wiki/Manual:$wgEnableUserEmail

So probably the code should be checking both.

github-actions[bot] commented 1 year ago

Image is built and pushed to the repository as ghcr.io/canastawiki/canasta:1.39.0-20221223-194

yaronkoren commented 1 year ago

@pastakhov - thanks for these fix suggestions! I think I added all of them. The double curly bracket was just a copying error. $wgSMTP defaults to false, not null, but you're right that we might as well check for everything.

github-actions[bot] commented 1 year ago

Image is built and pushed to the repository as ghcr.io/canastawiki/canasta:1.39.0-20221227-194

jeffw16 commented 1 year ago

I will refrain from providing a review until @pastakhov has had a chance to confirm his comments have been fixed to his satisfaction.

yaronkoren commented 1 year ago

@pastakhov - thanks for the comments! I'm embarrassed that I never actually checked this code on an MW 1.39 wiki. The "warningbox" class indeed did not work. I've fixed the code, and tested it, so now it should work better.

github-actions[bot] commented 1 year ago

Image is built and pushed to the repository as ghcr.io/canastawiki/canasta:1.39.0-20221228-194