search

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 28 forks source link

Add patch for removing errorbox from SMW extension #195

Closed sanjay-thiyagarajan closed 1 year ago

github-actions[bot] commented 1 year ago

Image is built and pushed to the repository as ghcr.io/canastawiki/canasta:1.39.0-20221224-195

yaronkoren commented 1 year ago

@pastakhov - oh, how interesting, it does look like SMW's informAboutExtensionAvailability() function no longer does anything, judging from the code.

Does anyone have access to a wiki running a version of SMW whose code is from less than a year ago (this change was made about a year ago), and would be willing to briefly disable SMW in their LocalSettings.php, to see if the warning in Special:Version no longer appears? It would be good to know for sure.

pastakhov commented 1 year ago

I don't see the warning in my 1.39 test wiki, but it is better to check it with somebody else for sure.

yaronkoren commented 1 year ago

I just confirmed that this code in fact does not run with MW 1.39. It should just be removed from SMW, but that's not our department. 😄 @sanjay-thiyagarajan - sorry about the unnecessary work you did for this. I'm closing this patch.