search

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 28 forks source link

Migrates HeaderFooter to Wikia fork #268

Closed vedmaka closed 1 year ago

vedmaka commented 1 year ago

Enterprisemediawiki version is broken on 1.39, this commit migrates the extension to Wikia version (REL1_39) branch

Solves #267

github-actions[bot] commented 1 year ago

:whale: The image based on c765c333 commit has been built with 1.39.1-20230727-268 tag as ghcr.io/canastawiki/canasta:1.39.1-20230727-268

yaronkoren commented 1 year ago

This looks good to me - the official NASA version is clearly not being well-maintained, so I'm glad that at least one organization is maintaining it. (Although I guess it's two, since Hallo Welt has their own version also.) It probably makes sense to talk to the Wikia/Fandom people (and maybe Hallo Welt also) about moving the good version of the code into the Wikimedia repository, but that's a separate conversation.

@vedmaka - one question: the current Header Footer documentation says that Composer is the recommended way to install this extension. Is that completely out of date at this point?

vedmaka commented 1 year ago

@yaronkoren That's right, in Wikia version it's an outdated instruction (they removed the autoloading part from the extension composer.json [1] )