CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 28 forks source link

Remove SemanticFormsSelect, Semantic Tasks from composer.canasta.json #274

Closed yaronkoren closed 1 year ago

yaronkoren commented 1 year ago

Neither of these extensions contain any Composer dependencies that need to be downloaded.

github-actions[bot] commented 1 year ago

:whale: The image based on 6edf8733 commit has been built with 1.39.1-20230814-274 tag as ghcr.io/canastawiki/canasta:1.39.1-20230814-274

vedmaka commented 1 year ago

Both extensions are still downloaded via Git here and here, and not installed via Composer, thus removing both extensions from the composer file breaks them because the autoload sections won't processed anymore [1] [2]. If we want to keep the extensions, we need to remove both from Dockerfile and instead add into https://github.com/CanastaWiki/Canasta-DockerCompose/blob/main/config/composer.local.json sample file require section to allow optional installation

yaronkoren commented 1 year ago

Oh, I didn't realize I need to look at the "autoload" section too. I'll revert this change now.

cicalese commented 1 year ago

But, they both have autoload statements in their extension.json files. They should not need the autoload statements in the composer.json files unless there is something missing from or incorrect in the statements in extension.json. In fact, it is bad form to have autoloading specified in both places and could potentially result in conflicts and confusion. Is there something wrong with the autoload statements in their extension.json files?