CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
36 stars 27 forks source link

Update version of WhosOnline #297

Closed DanielWTQ closed 1 year ago

DanielWTQ commented 1 year ago

The REL1_39 version has broken SQL, the fix for which (T328852) was only added to the master branch at the time. While it is available on the REL1_40 branch now, I believe it is preferable to use the master branch rather than a release-specific branch that is different from the targeted release (1.39).

Clone the (current) latest version of the master branch to include subsequent localization updates and other improvements since we are upgrading anyway.

DanielWTQ commented 1 year ago

Hmm, the pushing failed?

#94 exporting to image
#94 pushing layers 0.8s done
#94 ERROR: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden
------
 > exporting to image:
------
ERROR: failed to solve: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden
yaronkoren commented 1 year ago

Looks good to me! That "403 forbidden" error always happens when someone who doesn't have developer rights on this repo (or any of the other Canasta repos) creates a pull request. I assume there's some setting to fix this problem, but I don't know what it is.