CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
36 stars 27 forks source link

Images directory writable status not checked on container start #325

Closed vedmaka closed 1 month ago

vedmaka commented 10 months ago

When the container starts, it only checks for MW_VOLUME to be writable and not for the images directory. Because of this, if for any reason (e.g., images migration) the directory is not writable, it will stay not writable after the start and will lead to issues with image uploads and thumbnail generations until manually fixed on the host.

The proposal is to check for images directory writable status on start and change permissions as needed like it's done in Taqasta https://github.com/WikiTeq/Taqasta/blob/master/_sources/scripts/update-images-permissions.sh#L11

yaronkoren commented 1 month ago

I believe this is now fixed, thanks to some recent merging-in of WikiTeq code to the main Canasta branch.