CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
36 stars 27 forks source link

Remove the CanastaUtils.php file (remove error message about $wgSMTP) #349

Closed pastakhov closed 8 months ago

yaronkoren commented 8 months ago

@pastakhov - can you explain this change? Isn't it useful for people to know that emails will not be sent?

pastakhov commented 8 months ago

This is for the wikiteq branch, and the docker image can send emails well if Postfix on the host is configured to accept emails from the docker network. We usually configure postfix on all servers, and the message is confusing for us

yaronkoren commented 8 months ago

Oh, I didn't realize this was for the wikiteq branch. Thanks for the explanation.

Better yet, I would think, would be some flag to tell Canasta that mailing does work (outside of $wgSMTP). Or maybe Postfix can just be added to Canasta? I didn't realize this was a possibility.

pastakhov commented 8 months ago

It is easier to have one configured Postfix on the host which worries about sending email messages. All Canasta and any other service on the server needs is to send the emails to Postfix on the host. This is the best practice.

yaronkoren commented 8 months ago

Thanks for letting me know - I will definitely look into this Postfix thing.

Feel free to do whatever you want with this patch, though I still think the best option is to keep this code, but add another configuration variable for the PHP code to check, or some other way for the code to know that emailing is enabled.

github-actions[bot] commented 8 months ago

:whale: The image based on aaa9d71d commit has been built with 1.39.6-20240110-349 tag as ghcr.io/canastawiki/canasta:wikiteq-aaa9d71d

jeffw16 commented 5 months ago

By the way, I would highly recommend adding back the CanastaUtils.php file, even if it's empty. I understand that none of the contents were applicable to Taqasta, and I agree with removing those lines of code. However, removing files will make the Canasta–Taqasta divide even greater.

jeffw16 commented 5 months ago

We always reserve the right to add stuff to CanastaUtils.php, so I don't think we should be removing the file.