Move extensions setup to extensions.yaml and add shell script for execution

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.

https://www.canasta.wiki

MIT License

36 stars 27 forks source link

Move extensions setup to extensions.yaml and add shell script for execution #376

Closed naresh-kumar-babu closed 2 months ago

naresh-kumar-babu commented 3 months ago

Fixes #291 .

jeffw16 commented 3 months ago

This pull request introduces a nice new feature that will improve the quality of life for maintainers. That being said, while it can be very tempting to use a language like Python, it is slower and adds overhead that is otherwise unnecessary in this image. Please use a compiled language rather than an interpreted language.

jeffw16 commented 3 months ago

There are a few more reasons I do not think adding Python is a good idea:

I do not support adding unnecessary dependencies. Using Python for such a small script adds significant overhead to the image that is simply not worth it. I am sure Python seems like the obvious choice for ease of YAML parsing, but if you look to jq or yq in Bash, you'll see it's actually quite possible to do it in lower-level languages.
As President Kennedy once said, we don't do things because it's easy, but because it's hard. We should not simply use Python because it is an easy language. It is essentially the slowest interpreted language still in use today.

yaronkoren commented 3 months ago

@jeffw16 - thanks for looking at this. I have no idea what that quote means in this context, and I don't think the speed difference matters, but I do agree that it would be better to have this as a shell script, if it's possible. Hopefully those libraries you mentioned make it easy to do.

naresh-kumar-babu commented 2 months ago

Wonderful work, thank you! I hope these various iterations were not too irksome for you. I'm also hopeful this was a good learning opportunity, as writing good code here will pay dividends later if you work for a prestigious tech company (and of course for future open source projects too!).

Thank you. I did learn about yq and jq :)