search

CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
36 stars 27 forks source link

making various messages during setup more verbose #409

Closed naresh-kumar-babu closed 1 week ago

naresh-kumar-babu commented 1 week ago

Partial Fix #388 .

yaronkoren commented 1 week ago

@naresh-kumar-babu - I have to apologize, because I realize now that I don't remember - and can't figure out - which parts, if any, of the original patch (#371) have to do with making setup more verbose. A search on "verbose" and "-v" does not return anything meaningful. Maybe I misread the code before? I don't know. So perhaps this whole task should just be abandoned.

Now I'm curious, though: does adding a "-v" flag to the run-all.sh call have any impact? That script doesn't seem to have such a flag, as far as I can tell.

naresh-kumar-babu commented 1 week ago

@naresh-kumar-babu - I have to apologize, because I realize now that I don't remember - and can't figure out - which parts, if any, of the original patch (#371) have to do with making setup more verbose. A search on "verbose" and "-v" does not return anything meaningful. Maybe I misread the code before? I don't know. So perhaps this whole task should just be abandoned.

Now I'm curious, though: does adding a "-v" flag to the run-all.sh call have any impact? That script doesn't seem to have such a flag, as far as I can tell.

Even I could not find any. I thought this would be the one. Closing this PR.

yaronkoren commented 1 week ago

Okay, having looked more at the code, now I think I remember what this was about: it was just the addition of a few more "echo" calls, and making some of them longer - like changing "Starting job runner..." to "Starting job runner (in 10 seconds)...". Not really that important, but it is something.