CanastaWiki / Canasta

MediaWiki Docker image for Canasta, an all-in-one MediaWiki stack for easy deployment and management of enterprise-ready MediaWiki on production environments.
https://www.canasta.wiki
MIT License
38 stars 29 forks source link

1.39.1 to 1.39.8 Errors #456

Open fishpeopleapps opened 2 weeks ago

fishpeopleapps commented 2 weeks ago

We're attempting to upgrade to 1.39.8 using a hardened Canasta Image via Docker in a Kubernetes Container. We got it to finally go through in our staging environment, with the below new presenting errors:

CommentStreams Internal Error When attempting to delete or edit the action cannot be completed and this internal error pops up:

TypeError at /var/www/mediawiki/w/includes/dao/DBAccessObjectUtils.php
from /var/www/mediawiki/w/includes/dao/DBAccessObjectUtils.php(36)
0 /var/www/mediawiki/w/includes/dao/DBAccessObjectUtils.php(53): DBAccessObjectUtils::hasFlags()
1 /var/www/mediawiki/w/includes/page/WikiPageFactory.php(133): DBAccessObjectUtils::getDBOptions()
2 /var/www/mediawiki/w/includes/api/ApiBase.php(1057): MediaWiki\Page\WikiPageFactory->newFromID()
3 /var/www/mediawiki/w/canasta-extensions/CommentStreams/includes/ApiCSCommentBase.php(57): ApiBase->getTitleOrPageId()
4 /var/www/mediawiki/w/includes/api/ApiMain.php(1904): MediaWiki\Extension\CommentStreams\ApiCSCommentBase->execute()
5 /var/www/mediawiki/w/includes/api/ApiMain.php(879): ApiMain->executeAction()
6 /var/www/mediawiki/w/includes/api/ApiMain.php(850): ApiMain->executeActionWithErrorHandling()
7 /var/www/mediawiki/w/api.php(90): ApiMain->execute()
8 /var/www/mediawiki/w/api.php(45): wfApiMain()
9 {main}

Semantic MediaWiki When enabled has an "upgrade key error." I used the online updater which seems to have worked (not for SMW but our database updated). I would like to run the setupStore maintenance script but unsure of how to do this via a Dockerfile.

Moving a Page Internal Error When attempting to move a page this internal error pops up: /w/index.php?title=Special:MovePage&action=submit LogicException: This ParserOutput contains no text! But it does work if you deselect the box 'Leave a redirect behind'

MW Version Question Also, I watched the State of Canasta video at the recent conference, and MW 1.39.1 was referenced, and I see a recent commit from 1.39.8 to 1.39.1. What does this mean?

yaronkoren commented 2 weeks ago

Here are my thoughts on each of these:

fishpeopleapps commented 1 week ago

CommentStreams - ahh thank you for pointing that out! I will make sure I look at the extensions repo's first next time. How do I facilitate that change with Canasta, how/where do I find the commit reference that's used in the extensions.yaml file?

I can't get into our docker container. We are unable to use kubectl and while I can pull down the image and run the commands locally I can't push those to the staging environment from docker. Did running the setupStore and/or update maintenance script work for you to resolve the SMW issue?

Page Moving Error - it happens for all namespaces, even files.

Version - That makes sense, thank you for the clarification!

yaronkoren commented 1 week ago

Hi -

fishpeopleapps commented 1 week ago

Hello! CommentStreams - I made the changes in that commit (changing the frommasterdb to fromdbmaster in the 2 files) by using sed -I -e in my Dockerfile. It worked successfully!

SMW - I am unable to run commands like that in our container/our environment. But! I did figure out that I have to run update.php every time our container starts, this solves the error.

Yes, moving any page in any namespace and leaving a redirect always leads to that error. This actually occurred prior to the update to 1.39.8, it was present in 1.39.1 as well.

Thank you for your help! We're pushing to production soon with the new image!

yaronkoren commented 5 days ago

That's great that the CommentStreams update worked! The revision is now updated in the main Canasta code as well.

It's very strange that SMW requires update.php to be run every time... but good to know. And I'm glad you found a fix.

For the move-with-redirect bug: I did a web search on that error message, and found this. Are you using the Lingo extenson? If so, it sounds like another upgrade is in order: please try upgrading Lingo to this revision.