search

Candy-Labs / CandyContracts

Open-source NFT contract implementations
MIT License
11 stars 7 forks source link

Potentially incorrect check #12

Closed nullbitx8 closed 2 years ago

nullbitx8 commented 2 years ago

Hey, cool project!

While reading through the code I saw a potentially incorrect check

https://github.com/Candy-Labs/CandyContracts/blob/main/contracts/CandyCreatorV1A.sol#L372

I imagine it should be checking for require(_exists(... rather than require(!_exists(...

Cheers

kyokosdream commented 2 years ago

@nullbitx8 You're right, thank you! I changed an ERC721A revert error to a require with a custom string and so this should be changed ASAP.

kyokosdream commented 2 years ago

Fixed in the latest commit. Thanks for your help. We just updated our contract to v3.0 of ERC721A and would have missed this without you.

Please do open any other issues. If you'd like to drop a wallet address we'd love to send a small bug bounty to you for catching this critical bug.

nullbitx8 commented 2 years ago

Np, glad to help! Great job on the project!